Ignore unknown command-line arguments #4216
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebr
requested review from
Kyle0654,
blessedcoolant,
psychedelicious and
brandonrising
as code owners
lstein
reviewed
Aug 9, 2023
There was a problem hiding this comment.
It works, but I'd like to hear some more commentary on this from other team members.
I'd thought of doing this a while ago, but then I realized that this would no longer catch typos in the command line arguments. For example, someone types:
invokeai-web --db-dir /foo/bar/invokeai.db
The command works, but why isn't it picking up the correct database? Oh, because the correct switch is: --db_dir, not --db-dir.
1 task
psychedelicious
added a commit
that referenced
this pull request
Sep 8, 2023
Do not throw when parsing unknown args, instead parse only known args print the unknown ones (supersedes #4216)
hipsterusername
pushed a commit
that referenced
this pull request
Sep 8, 2023
Do not throw when parsing unknown args, instead parse only known args print the unknown ones (supersedes #4216)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when unknown CLI arguments are encountered,
argparseexits with an error.This PR changes that so that unknown CLI args are silently ignored. Particularly this enables running the
uvicornserver directly, taking advantage of hot-reloading in development, like so:uvicorn invokeai.app.api_app:app --reload.What type of PR is this? (check all applicable)
Have you discussed this change with the InvokeAI team?
Have you updated all relevant documentation?