Skip to content

Conversation

greatwolf
Copy link
Contributor

This fixes an import issue introduced in commit 1bfe983. The change made 'invokeai_configure' into a module but this line still tries to call it as if it's a function. This will result in a 'module' not callable error.

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update
  • Community Node Submission

Have you discussed this change with the InvokeAI team?

  • Yes
  • No, because:

Have you updated all relevant documentation?

  • Yes
  • No

Description

imic from discord ask that I submit a PR to fix this bug.

Related Tickets & Documents

  • Related Issue #
  • Closes #

QA Instructions, Screenshots, Recordings

Added/updated tests?

  • Yes
  • No : please replace this line with details on why tests
    have not been included

[optional] Are there any post deployment tasks we need to perform?

This fixes an import issue introduced in commit 1bfe983.
The change made 'invokeai_configure' into a module but this line still tries to call it as if it's a function. This will result in a `'module' not callable` error.
@greatwolf greatwolf requested review from lstein and ebr as code owners August 13, 2023 12:23
@blessedcoolant
Copy link
Collaborator

blessedcoolant commented Aug 13, 2023

There's also a similar import from invokeai.frontend.install import invokeai_configure in configure_invokeai.py .. Could you add fix that up too please?

@greatwolf
Copy link
Contributor Author

Just to make sure I have the right spot, is it this line?

from invokeai.frontend.install import invokeai_configure as configure

@blessedcoolant
Copy link
Collaborator

Just to make sure I have the right spot, is it this line?

from invokeai.frontend.install import invokeai_configure as configure

Yes. I think that's the same import issue as the one you fixed in the PR.

@greatwolf
Copy link
Contributor Author

done, hopefully that's all of it.

@blessedcoolant blessedcoolant self-assigned this Aug 13, 2023
@blessedcoolant blessedcoolant self-requested a review August 13, 2023 12:34
@blessedcoolant
Copy link
Collaborator

Simple enough PR. I'm gonna override code owner review for this. Merging when checks pass.

@greatwolf Thanks for the PR.

@blessedcoolant blessedcoolant merged commit 250d530 into invoke-ai:main Aug 13, 2023
@greatwolf greatwolf deleted the bugfix/import-issue-model_install branch July 15, 2024 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants