Skip to content

Conversation

lstein
Copy link
Collaborator

@lstein lstein commented Aug 15, 2023

What type of PR is this? (check all applicable)

  • Feature
  • Bug Fix

Have you discussed this change with the InvokeAI team?

  • Yes

Have you updated all relevant documentation?

  • [X Yes

Description

Enables correct detection and installation of SDXL-base controlnet models.

Related Tickets & Documents

https://discord.com/channels/1020123559063990373/1085428210969358366/1141024732800614500

Added/updated tests?

  • No : I'm planning to do a rewrite of the model probe code and will add tests at this point.

Copy link
Contributor

@GreggHelt2 GreggHelt2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, so that's why all the SDXL 1.0 ControlNet models I've tried so far have ended up being downloaded to .../models/sd-2 instead of .../models/sdxl
I was able to use them by manually moving to sdxl dir, but glad this is getting fixed!

@hipsterusername hipsterusername merged commit d6c9bf5 into main Aug 15, 2023
@hipsterusername hipsterusername deleted the bugfix/detect-sdxl-controlnet branch August 15, 2023 16:51
@lstein
Copy link
Collaborator Author

lstein commented Aug 15, 2023 via email

@GreggHelt2
Copy link
Contributor

If you notice anomalies like this, post an issue or discord message. It was a very easy fix once I knew about the issue! Lincoln

I did mention this a few days ago in a discord message chain: https://discord.com/channels/1020123559063990373/1042475531079262378/1140259204716838992
But that was in #contributor-chat, I probably should have crossposted to #model-management

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants