Skip to content

Conversation

blessedcoolant
Copy link
Collaborator

@blessedcoolant blessedcoolant commented Aug 16, 2023

What type of PR is this? (check all applicable)

  • Feature

Have you discussed this change with the InvokeAI team?

  • Yes

Description

PR to add Seam Painting back to the Canvas.

TODO Later

While the graph works as intended, it has become extremely large and complex. I don't know if there's a simpler way to do this. Maybe there is but there's soo many connections and visualizing the graph in my head is extremely difficult. We might need to create some kind of tooling for this. Coz it's going going to get crazier.

But well works for now.

@blessedcoolant blessedcoolant changed the title (wip): Seam Painting (feat): Add Seam Painting to Canvas (1.x, 2.x & SDXL) Aug 16, 2023
@blessedcoolant blessedcoolant changed the title (feat): Add Seam Painting to Canvas (1.x, 2.x & SDXL) (feat): Add Seam Painting to Canvas (1.x, 2.x & SDXL w/ Refiner) Aug 16, 2023
@blessedcoolant blessedcoolant marked this pull request as ready for review August 16, 2023 07:49
Copy link
Collaborator

@psychedelicious psychedelicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gonna be honest, I tested this but do not have it in me to actually review the graph logic. YOLO

@blessedcoolant
Copy link
Collaborator Author

Gonna be honest, I tested this but do not have it in me to actually review the graph logic. YOLO

I'm pretty confident this is probably the least number of nodes that are to be used in order to achieve this but the number of intermediate images that get saved when you scale before processing really adds up coz you scale up and then scale down again.

But that's another problem entirely. I've done more testing and it seems like Seam Painting is doing what it should.

Now in order to get outpainting to work great, I think we have to implement the full LaMa infilling or some other more robust infilling method.

But right now this should have parity with what we had before.

Merging it.

@blessedcoolant blessedcoolant merged commit 89b82b3 into invoke-ai:main Aug 17, 2023
@blessedcoolant blessedcoolant deleted the seam-painting branch August 17, 2023 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants