stats: handle exceptions #4320
Merged
stats: handle exceptions #4320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When retrieving a graph, it is parsed through pydantic. It is possible that this graph is invalid, and an error is thrown. Handle this by deleting the failed graph from the stats if this occurs.
- move docstrings to ABC - `start_time: int` -> `start_time: float` - remove class attribute assignments in `StatsContext` - add `update_mem_stats()` to ABC - add class attributes to ABC, because they are referenced in instances of the class. if they should not be on the ABC, then maybe there needs to be some restructuring
psychedelicious
requested review from
Kyle0654,
blessedcoolant and
brandonrising
as code owners
|
I also fixed some typing issues in the stats module. |
blessedcoolant
approved these changes
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
fix(stats): fix fail case when previous graph is invalid
When retrieving a graph, it is parsed through pydantic. It is possible that this graph is invalid, and an error is thrown.
Handle this by deleting the failed graph from the stats if this occurs.
fix(stats): fix InvocationStatsService types
start_time: int->start_time: floatStatsContextupdate_mem_stats()to ABCQA Instructions, Screenshots, Recordings
On
main(not this PR), create a situation in which an graph is valid but will be rendered invalid on invoke. Easy way in node editor:Integer Primitivenode, set value to 3Resize Imagenode and add an image to itInteger Primitiveto thewidthofResize ImageValidation Error(expected), and if you inspect the error in the JS console, you'll see it is a "session retrieval error"Validation Error, but if you inspect the error you should see it originates in the stats module (this is the error this PR fixes)Integer Primitiveto 512Validation Errororiginating from stats, even tho there are no issuesSwitch to this PR, and then you should only ever get the
Validation Errorthat that is classified as a "session retrieval error".