Skip to content

Conversation

webpro
Copy link
Contributor

@webpro webpro commented Apr 14, 2024

Summary

The other day someone asked for an example of Knip + Storybook including production mode. GitHub search led me to this repo. And then I was happy to see Knip being used in a great manner :)

One thing struck me, though, so here I am proposing a small change so Knip will stay out of your way even more.

This also enables knip --production, which to me seems to reveal some unused exports you might to remove as well, but I'm leaving that up to you.

Related Issues / Discussions

N/A

QA Instructions

CI should still pass. You could consider adding another task to additionally run knip --production as well.

Merge Plan

N/A

Checklist

  • The PR has a short but descriptive title, suitable for a changelog
  • Tests added / updated (if applicable)
  • Documentation added / updated (if applicable)

@github-actions github-actions bot added frontend-deps PRs that change frontend dependencies frontend PRs that change frontend files labels Apr 14, 2024
@webpro webpro changed the title Knip config Fix up Knip config & enable --production mode Apr 14, 2024
@webpro webpro force-pushed the chore/knip-config branch from 97e5dea to dfd95cd Compare April 14, 2024 12:24
@psychedelicious
Copy link
Collaborator

Thank you! Nice to use paths instead of explicit ignores, I couldn't figure that part out before. I'll review strict & production mode and make adjustments as needed.

Thanks for knip, it's a very useful tool.

@psychedelicious psychedelicious merged commit 06bc38d into invoke-ai:main Apr 14, 2024
@webpro webpro deleted the chore/knip-config branch April 15, 2024 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend PRs that change frontend files frontend-deps PRs that change frontend dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants