Skip to content

perf(ui): misc ui improvements #6225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 15, 2024
Merged

perf(ui): misc ui improvements #6225

merged 3 commits into from
Apr 15, 2024

Conversation

psychedelicious
Copy link
Collaborator

Summary

A few perf improvements:

  • Extraneous rerenders in workflow editor
  • Extraneous calculations in useFeatureStatus
  • Memoize some state in infill components

Related Issues / Discussions

n/a

QA Instructions

n/a

Merge Plan

n/a

Checklist

  • The PR has a short but descriptive title, suitable for a changelog
  • Tests added / updated (if applicable) n/a
  • Documentation added / updated (if applicable) n/a

@github-actions github-actions bot added the frontend PRs that change frontend files label Apr 15, 2024
@psychedelicious psychedelicious enabled auto-merge (rebase) April 15, 2024 12:48
@psychedelicious psychedelicious force-pushed the psyche/perf/ui/node-editor-perf branch from 20edc2f to 71ebf73 Compare April 15, 2024 12:49
@psychedelicious psychedelicious merged commit 5a8489b into main Apr 15, 2024
@psychedelicious psychedelicious deleted the psyche/perf/ui/node-editor-perf branch April 15, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hipsterusername hipsterusername hipsterusername approved these changes

@blessedcoolant blessedcoolant Awaiting requested review from blessedcoolant blessedcoolant is a code owner

@maryhipp maryhipp Awaiting requested review from maryhipp maryhipp is a code owner

Assignees
No one assigned
Labels
frontend PRs that change frontend files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@psychedelicious @hipsterusername