feat(ui): various error toast optimizations #6409
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st but also dedupe
maryhipp
requested review from
psychedelicious,
blessedcoolant and
hipsterusername
as code owners
maryhipp
commented
May 20, 2024
| description: startCase(action.payload.data.error_type), | ||
| }) | ||
| ); | ||
| const errorType = startCase(action.payload.data.error_type); |
There was a problem hiding this comment.
If we aren't using state, maybe this would be better as a listener?
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related Issues / Discussions
QA Instructions
Easiest way to test is to make a workflow that divides integers zero by zero. Queue up multiple and should only appear for the first one. If you dismiss toast before the queue is complete, another one should pop in its place.
Merge Plan
Checklist