[MM2] Use typed ModelRecordChanges for model_install() rather than untyped dict #6645
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ModelRecordChanges - adjusted frontend to work with new schema - used this facility to assign "starter model" names and descriptions to the installed models.
lstein
requested review from
psychedelicious,
blessedcoolant,
maryhipp,
hipsterusername,
brandonrising and
RyanJDick
as code owners
github-actions
bot
added
api
python
…ModelRecordChanges - adjusted frontend to work with new schema - used this facility to assign "starter model" names and descriptions to the installed models.
lstein
force-pushed
the
lstein/feat/starter-descriptions
branch
from
8a3617e to
3ed47de
Compare
psychedelicious
approved these changes
Jul 23, 2024
There was a problem hiding this comment.
Looks good! I was just wishing for this today when I installed the SwinIR upscaling model, which has a fifty-thousand character name by default.
I'll request a review from @brandonrising too.
.../src/features/modelManagerV2/subpanels/AddModelPanel/StarterModels/StartModelsResultItem.tsx
Outdated
Show resolved
Hide resolved
.../src/features/modelManagerV2/subpanels/AddModelPanel/StarterModels/StartModelsResultItem.tsx
Outdated
Show resolved
Hide resolved
brandonrising
approved these changes
Jul 23, 2024
…ai/InvokeAI into lstein/feat/starter-descriptions
…ModelRecordChanges - adjusted frontend to work with new schema - used this facility to assign "starter model" names and descriptions to the installed models.
…ModelRecordChanges - adjusted frontend to work with new schema - used this facility to assign "starter model" names and descriptions to the installed models.
psychedelicious
added a commit
that referenced
this pull request
Jul 23, 2024
#6645 inadvertently removed the lockfile
3 tasks
psychedelicious
added a commit
that referenced
this pull request
Jul 23, 2024
#6645 inadvertently removed the lockfile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The various model manager install calls previously accepted a dict object called
configcontaining fields to override the autoprobed model configuration values. This PR replaces this with a typed pydantic objectModelRecordChanges. This is the same class that is used for model record updates.This PR takes advantage of this change to write the name and description of the curated "starter models" into the model record database. Note that this is my first foray into typescript, and may not have implemented the necessary changes in the most elegant way.
Related Issues / Discussions
Closes #6528
QA Instructions
After running the back and frontends, try the following:
Merge Plan
Merge when approved.
Checklist