Add a workaround for broken sliced attention on MPS with torch 2.4.1 #7066
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RyanJDick
requested review from
blessedcoolant,
brandonrising,
hipsterusername and
lstein
as code owners
github-actions
bot
added
python
1 task
RyanJDick
force-pushed
the
ryan/fix-mps-attn-torch241
branch
from
fb3a332 to
4b63bfc
Compare
…e pin the torch version, so there should be no concern that this function does not exist.
psychedelicious
force-pushed
the
ryan/fix-mps-attn-torch241
branch
from
4b63bfc to
2678b4c
Compare
hipsterusername
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a workaround for broken sliced attention on MPS with torch 2.4.1. The workaround keeps things working on MPS at the cost of increased peak memory utilization. Users who are unhappy with this should manually downgrade to
torch==2.2.2.Related Issues / Discussions
Bug report: #7049
QA Instructions
Checklist