Skip to content
This repository has been archived by the owner on May 19, 2021. It is now read-only.

Private Message implementation #108

Closed
wants to merge 28 commits into from
Closed

Conversation

Lyra2108
Copy link
Member

@Lyra2108 Lyra2108 commented Jun 1, 2015

No description provided.

@MAH1987
Copy link
Member

MAH1987 commented Jun 8, 2015

when nobody has comments this PR can be merged!

confirm_action_flash.html
~~~~~~~~~~~~~~~~~~~~~~~~~

:copyright: (c) 2011-2015 by the Inyoka Team, see AUTHORS for more details.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change all the copyright-dates to 2013-2015. (→ does not only affect this file)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check

@chris34
Copy link
Member

chris34 commented Jun 8, 2015

no comments != perfect code. So i made a fast review by only watching at the source-code without knowing what the code does. Hopefully, it was not too much spam… ;)

</div>
{%- endif %}

<form action="" method="post">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

form-macros will not give (a lot of) reduction of the source code. However, it would be more consistent to use them here, too, imho.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now use form-macro, but the submitbutton has to place in the innerform-markup. have to wait for pr #105?

@media (max-width: @screen-xs-max) {
position: relative;
}
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

less does not want to compile because of this block. Is it even needed as there are no <dd>/<dt> anymore?

@chris34
Copy link
Member

chris34 commented Sep 21, 2015

@Lyra2108 is no working on this in #137

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants