[types]: Groups and users can have name as StringOrTranslated too (e.g. admins) #2876
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
foxriver76
reviewed
Aug 25, 2024
| interface UserCommon extends ObjectCommon { | ||
| /** The username */ | ||
| name: string; | ||
| name: StringOrTranslated; |
There was a problem hiding this comment.
I am still not a big fan of having translated usernames anywhere. If necessary - okay..
There was a problem hiding this comment.
It is already used. administrator group and admin user are already multi-language for a long long time
foxriver76
requested changes
Aug 25, 2024
Done |
foxriver76
changed the title
foxriver76
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users and groups could be multi-translated