Split all value dimensions when splitting by path color #2990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippjfr
added
type: bug
philippjfr
force-pushed
the
path_split_vdims
branch
from
c2d8693
to
e9771ad
Compare
|
@jlstevens Ready to review and once merged a dev release would be helpful. |
jlstevens
reviewed
Sep 13, 2018
| if clmin == clmax: | ||
| idx = np.argmin(np.abs(np.array(levels)-clmin)) | ||
| clip = levels[idx: idx+2] if len(levels) > idx+2 else levels[idx-1: idx+1] | ||
| return cmap, clip |
There was a problem hiding this comment.
Now the return value has changed (or at least now includes clip) it might be worth updating the docstring...
|
This change makes a lot of sense. Other than one minor comment to address, I am happy to merge. |
|
Looks good to me. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When displaying a path with a varying value dimension used to color each line segment the path is split into little chunks. However previously other value dimensions would not be split in this way which would cause several issues:
The solution is to split all value dimensions by default.