-
-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor of IPython extension and rendering #308
Conversation
I've skimmed through the PR and it looks pretty good to me. Nice to see deletion from the IPython extension without a corresponding increase elsewhere. The approach of using renderer instance to keep track of the options (i.e as parameters) is very nice. What in particular isn't ready yet? Is there anything you would like me to look at in more detail? |
a5510fa
to
9c3b1a3
Compare
427d4fc
to
8434e3f
Compare
759549e
to
1791959
Compare
22c756b
to
d0f4747
Compare
d0f4747
to
ed949c7
Compare
a5408ef
to
85f7e4a
Compare
@@ -12,44 +12,6 @@ | |||
|
|||
archive = FileArchive() | |||
|
|||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moving these two functions to util
does make sense.
Just a few comments (I'll extend this list as I go along):
Other than these points and a few other comments I've made in the commits, I am very happy with this PR and ready to merge it! |
@classmethod | ||
def validate(cls, options): | ||
""" | ||
Validates a dictionary of options set on the backend. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the docstring should be something like "Validate an options dictionary for the renderer"
. The reason is that I would say that 'renderer' is a holoviews term (subclass of Renderer
) whereas the 'backend' is the library or 3rd party tool used by the renderer. Very closely related, I agree, but not quite the same thing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, why not make validate
accept **kwargs
instead of a dictionary of options? Ends up being the same thing but maybe a nicer interface for validation. Just something to consider.
Ok, I'm happy with this refactor. It really cleans things up and removing code from the ipython extension is always a good thing. |
Refactor of IPython extension and rendering
It is now merged and working. There is one more thing I would like to fix before 1.4 - currently the constructor of For generators, that means using I'm happy to implement this change if Philipp tells me where he thinks this initialization should go. I can definitely remove this initialization from the |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This PR will refactor the OutputMagic and display hooks such that they are backend independent and move some of the display machinery onto the Renderers. This will make the IPython extension cleaner and make it much easier to add new output formats and renders, and allow for static HTML exporting.
The PR is far from ready for merging.