Various small fixes for GridColumns #559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippjfr
added
in progress
type: bug
philippjfr
force-pushed
the
gridcolumns_fixes
branch
from
dbdbd3c
to
2690727
Compare
|
Ready to merge. |
|
Looks good and the tests are passing. Merging. |
jlstevens
added a commit
that referenced
this pull request
Mar 19, 2016
Various small fixes for GridColumns
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some small bugs snuck in when I was cleaning up GridColumns before it was merged in #542. I've addressed those bugs, improved error handling and added a unit test for groupby operations. I've also made sure that the GridColumns interface handles 0D or scalar data to ensure that groupby operations work even one a 1D GridColumns object.