Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The annotation values in the format field of the vcf are not showing. #1028

Closed
tonydisera opened this issue Oct 23, 2023 · 2 comments
Closed
Assignees
Labels
bug Something isn't working review complete
Milestone

Comments

@tonydisera
Copy link
Collaborator

I select the format annotation fields, which have values, but all value are blank in the VariantInspectCard.
Screenshot 2023-10-22 at 6 29 23 PM
Screenshot 2023-10-22 at 6 31 11 PM

@tonydisera tonydisera added the bug Something isn't working label Oct 23, 2023
@tonydisera tonydisera added this to the 4.9 milestone Oct 23, 2023
@tonydisera
Copy link
Collaborator Author

tonydisera commented Oct 23, 2023

@YangQi007, can you look at this as soon as possible? I'd like to have a fix before we release. You will need to create a new branch from 4.9 as there have been quite a few changes.
Thanks! Tony

@YangQi007
Copy link
Collaborator

Hi, @tonydisera I noticed that you added some code in getting formatValues, I am confused about this line of code, cause if this line of code is added, we cannot get the formatValues.
Screenshot 2023-10-22 at 8 27 53 PM

@tonydisera tonydisera assigned tonydisera and unassigned YangQi007 Oct 23, 2023
tonydisera added a commit that referenced this issue Jan 2, 2024
* tag 'gene_4.9': (86 commits)
  Fix // double forward-slash problem in URL.
  No longer override host for gene2pheno and geneinfo (hardcoded to point to Mosaic server).
  #1035 - Fix code so that we only get the Mosaic variant when necessary. That is, we only call the function promiseGetMosaicVariant when the user has selected a variant and there is at least one Mosaic annotation that has been checked.
  Resolved the changes requested#1036
  Backout code that attempted to create a hub session when gene is in iframe in clin.iobio. This won't work as iframe does not share parent's session.
  #1035 When gene is within clin.iobio, launched from Mosaic, initalize a hub session and load the Mosaic variant annotation map so that checkboxes for Mosaic variant annotations appear in 'Select custom annotations' dialog
  Fixed the mosaic annots not updated#1035
  Cleaned up the code for debugging
  Fixed cancel button behavior#1027
  Fixed the order of showing annots case sensitive and alphabetically#1025
  #1029 If INFO or FORMAT header rec cannot be parsed, print message to console about field being bypassed. Fix bug that was returning previous record when match failed.
  The style was not scoped to just this Gene Associations Dialog. Fix by adding parent container selector.
  Make Edit Filter dialog shorter so that it will fit in frame of gene.iobio in clin.iobio. See #1031
  Fixed the buttons not showing in clin.#1031 Add an id at runtime to the dialog so that the styling is scoped to the Edit Filter dialog.
  Don't show all of the search hits in the Variants side panel when launched w/i clin.iobio #1023 - Also sort the entries so that lowest ranks appear first.
  The phenolyzer search hits don't show on dialog 'Show more' when gene.iobio runs w/i clin.iobio #1024
  Fixed the regular expression to show SAC#1029
  Need more height for Gene disease associations in Gene-Phenotype associations dialog. #1022
  The annotation values in the format field of the vcf are not showing. #1028
  For selecting custom annotations, simplify code by removing of unnecessary data fields #1026 - Get rid of data field selectedInfo. Instead pass property selectedVariantInfo into SelectVariantAnnotationsDialog and emit the dialogs event, passing the event parameter directly in the emit that will be received by GeneHome.
  ...
tonydisera added a commit that referenced this issue Jan 2, 2024
* tag 'gene_4.9': (77 commits)
  Fix // double forward-slash problem in URL.
  No longer override host for gene2pheno and geneinfo (hardcoded to point to Mosaic server).
  #1035 - Fix code so that we only get the Mosaic variant when necessary. That is, we only call the function promiseGetMosaicVariant when the user has selected a variant and there is at least one Mosaic annotation that has been checked.
  Resolved the changes requested#1036
  Backout code that attempted to create a hub session when gene is in iframe in clin.iobio. This won't work as iframe does not share parent's session.
  #1035 When gene is within clin.iobio, launched from Mosaic, initalize a hub session and load the Mosaic variant annotation map so that checkboxes for Mosaic variant annotations appear in 'Select custom annotations' dialog
  Fixed the mosaic annots not updated#1035
  Cleaned up the code for debugging
  Fixed cancel button behavior#1027
  Fixed the order of showing annots case sensitive and alphabetically#1025
  #1029 If INFO or FORMAT header rec cannot be parsed, print message to console about field being bypassed. Fix bug that was returning previous record when match failed.
  The style was not scoped to just this Gene Associations Dialog. Fix by adding parent container selector.
  Make Edit Filter dialog shorter so that it will fit in frame of gene.iobio in clin.iobio. See #1031
  Fixed the buttons not showing in clin.#1031 Add an id at runtime to the dialog so that the styling is scoped to the Edit Filter dialog.
  Don't show all of the search hits in the Variants side panel when launched w/i clin.iobio #1023 - Also sort the entries so that lowest ranks appear first.
  The phenolyzer search hits don't show on dialog 'Show more' when gene.iobio runs w/i clin.iobio #1024
  Fixed the regular expression to show SAC#1029
  Need more height for Gene disease associations in Gene-Phenotype associations dialog. #1022
  The annotation values in the format field of the vcf are not showing. #1028
  For selecting custom annotations, simplify code by removing of unnecessary data fields #1026 - Get rid of data field selectedInfo. Instead pass property selectedVariantInfo into SelectVariantAnnotationsDialog and emit the dialogs event, passing the event parameter directly in the emit that will be received by GeneHome.
  ...

# Conflicts:
#	client/app/components/pages/GeneHome.vue
#	client/app/globals/GlobalApp.js
#	package.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working review complete
Projects
None yet
Development

No branches or pull requests

2 participants