-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
If I am viewing a revision, autosave should be off by default #1593
Comments
added some thoughts on the strategy at #1592 |
I mentioned some of my thoughts on this there: The pertinent suggestion is:
I would suggest communicating this state (and the possible actions) via the header bar. |
wlach
added a commit
to wlach/iodide
that referenced
this issue
Mar 11, 2019
* Don't autosave if viewing an old revision (fixes iodide-project#1593) * Check freshness of notebook when switching to it, disable autosaving if it is determined to be out of date
wlach
added a commit
to wlach/iodide
that referenced
this issue
Mar 11, 2019
* Don't autosave if viewing an old revision (fixes iodide-project#1593) * Check freshness of notebook when switching to it, disable autosaving if it is determined to be out of date
3 tasks
wlach
added a commit
to wlach/iodide
that referenced
this issue
Mar 20, 2019
* Don't autosave if viewing an old revision (fixes iodide-project#1593) * Check freshness of notebook when switching to it, disable autosaving if it is determined to be out of date
wlach
added a commit
to wlach/iodide
that referenced
this issue
Mar 22, 2019
* Don't autosave if viewing an old revision (fixes iodide-project#1593) * Check freshness of notebook when switching to it, disable autosaving if it is determined to be out of date
wlach
added a commit
to wlach/iodide
that referenced
this issue
Mar 25, 2019
* Don't autosave if viewing an old revision (fixes iodide-project#1593) * Check freshness of notebook when switching to it, disable autosaving if it is determined to be out of date
wlach
added a commit
to wlach/iodide
that referenced
this issue
Mar 25, 2019
* Don't autosave if viewing an old revision (fixes iodide-project#1593) * Check freshness of notebook when switching to it, disable autosaving if it is determined to be out of date
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We are quickly getting to the point where we need a real strategy around how revisions operate (which is exciting!), but if I am viewing a revision, I believe we should probably have all autosave off by default until we have a better idea. The point of viewing a revision in a notebook (for now) should be primarily to investigate how something works. With #1565, however, viewing a revision will quickly begin adding another revision to the stack, which is most assuredly an unintended side-effect.
So we will need some strategy / reasoning around how to adequately view revisions. The revision viewer is really not enough, since the point of viewing a revision is so I can run it and check the code logic and report, not just looking at the source.
The text was updated successfully, but these errors were encountered: