Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If I am viewing a revision, autosave should be off by default #1593

Closed
hamilton opened this issue Mar 7, 2019 · 2 comments
Closed

If I am viewing a revision, autosave should be off by default #1593

hamilton opened this issue Mar 7, 2019 · 2 comments

Comments

@hamilton
Copy link
Contributor

hamilton commented Mar 7, 2019

We are quickly getting to the point where we need a real strategy around how revisions operate (which is exciting!), but if I am viewing a revision, I believe we should probably have all autosave off by default until we have a better idea. The point of viewing a revision in a notebook (for now) should be primarily to investigate how something works. With #1565, however, viewing a revision will quickly begin adding another revision to the stack, which is most assuredly an unintended side-effect.

So we will need some strategy / reasoning around how to adequately view revisions. The revision viewer is really not enough, since the point of viewing a revision is so I can run it and check the code logic and report, not just looking at the source.

@bcolloran
Copy link
Contributor

added some thoughts on the strategy at #1592

@wlach
Copy link
Contributor

wlach commented Mar 8, 2019

I mentioned some of my thoughts on this there:
#1592 (comment)

The pertinent suggestion is:

Maybe if the user is looking at an older revision of a notebook, we could just turn off autosave, but give the user an option to:

1. Save the revision to a _new notebook_

2. Overwrite the existing notebook

I would suggest communicating this state (and the possible actions) via the header bar.

wlach added a commit to wlach/iodide that referenced this issue Mar 11, 2019
* Don't autosave if viewing an old revision (fixes iodide-project#1593)
* Check freshness of notebook when switching to it, disable autosaving
  if it is determined to be out of date
wlach added a commit to wlach/iodide that referenced this issue Mar 11, 2019
* Don't autosave if viewing an old revision (fixes iodide-project#1593)
* Check freshness of notebook when switching to it, disable autosaving
  if it is determined to be out of date
wlach added a commit to wlach/iodide that referenced this issue Mar 20, 2019
* Don't autosave if viewing an old revision (fixes iodide-project#1593)
* Check freshness of notebook when switching to it, disable autosaving
  if it is determined to be out of date
wlach added a commit to wlach/iodide that referenced this issue Mar 22, 2019
* Don't autosave if viewing an old revision (fixes iodide-project#1593)
* Check freshness of notebook when switching to it, disable autosaving
  if it is determined to be out of date
wlach added a commit to wlach/iodide that referenced this issue Mar 25, 2019
* Don't autosave if viewing an old revision (fixes iodide-project#1593)
* Check freshness of notebook when switching to it, disable autosaving
  if it is determined to be out of date
wlach added a commit to wlach/iodide that referenced this issue Mar 25, 2019
* Don't autosave if viewing an old revision (fixes iodide-project#1593)
* Check freshness of notebook when switching to it, disable autosaving
  if it is determined to be out of date
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants