Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build tune-ups (webpack not shaking tree correctly / not reading NODE_ENV options correctly) #2023

Closed
bcolloran opened this issue Jul 15, 2019 · 4 comments
Closed

build tune-ups (webpack not shaking tree correctly / not reading NODE_ENV options correctly) #2023

bcolloran opened this issue Jul 15, 2019 · 4 comments
Assignees
@wlach

Comments

@bcolloran
Copy link
Contributor

we should set our "build" mode to be a "production" mode (which will have minification and tree shaking and will prevent some debug messages from being surfaced in the devtools console), and deprecate the "build-prduction" mode, which we don't seem to be using anywhere.

thanks @dmose for noticing this.

cc @wlach
@bcolloran
Copy link
Contributor Author

also, this may need to include removing ".dev" from a bunch of our filenames

@wlach
Copy link
Contributor

wlach commented Jul 16, 2019 •
edited
Loading

💯

I'd prefer to wait on this until #1943 is fixed, but this would be a good issue for a contributor to pick up when that's done

@bcolloran
Copy link
Contributor Author

now that #1943 is fixed, this is ready for work. as will says, this could be a good first issue for a contributor.

@wlach wlach self-assigned this Oct 30, 2019
@wlach
Copy link
Contributor

wlach commented Oct 30, 2019

I'm going to take this one

wlach added a commit to wlach/iodide that referenced this issue Oct 30, 2019
@wlach
Use webpack production mode for building iodide (fixes iodide-project…
ed48f38 
…#2023)

Also, use terser-js (uglify doesn't support some ES6 constructs we now use).
This shaves over a megabyte off of the uncompressed file sizes for our
js bundles.
@wlach wlach closed this as completed in 2590b8f Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wlach wlach

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wlach @bcolloran