Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No evaluator available for chunks of type #2215

Closed
louisabraham opened this issue Sep 4, 2019 · 3 comments
Closed

No evaluator available for chunks of type #2215

louisabraham opened this issue Sep 4, 2019 · 3 comments
Labels

Comments

@louisabraham
Copy link
Contributor

Hi, this demo doesn't work anymore https://alpha.iodide.io/notebooks/1627/

%% plugin

{
  "languageId": "ml",
  "displayName": "OCaml",
  "codeMirrorMode": "mllike",
  "url": "https://louisabraham.github.io/domical/eval.js",
  "module": "evaluator",
  "evaluator": "execute",
  "pluginType": "language"
}

%% ml
open Printf
let my_data = [ "a"; "beautiful"; "day" ]
let () = List.iter (fun s -> printf "%s\n" s) my_data

The output is the following:

image

@wlach
Copy link
Contributor

wlach commented Sep 5, 2019

Weirdly, after taking out the codeMirrorMode key out from the language plugin directive, everything seems to work:

https://alpha.iodide.io/notebooks/3183/

We no longer use codemirror in iodide so it's no longer necessary, but I don't see why it should be causing the language plugin not to work.

@wlach wlach added the bug label Sep 5, 2019
@bcolloran
Copy link
Contributor

oh i bet it's probably failing at state schema validation. it's probably an easy fix to have it not fail if there are extra keys (and/or to give better feedback in case the plugin info is not valid for some reason).

(note that adding Monaco syntax highlighting for additional languages is not working at present)

@mdboom
Copy link
Contributor

mdboom commented Sep 10, 2019

Yeah -- this seems like a good place to not be strict about extra keys.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants