-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrate diff viewer to use monaco's diff viewer #2275
Comments
little more on this: i'm not sure how involved this will be; it might be tricky or it might be pretty easy. we'd need to create a custom component to instantiate the monaco diff viewer, along the lines of the editor component but i think waaaay simpler since the state updating would not need to be so sophisticated -- i think we could write it as it's own component that could just take the same props as |
FWIW, our usage of react-diff-viewer is very very simple (as is the component):
|
monaco editor comes with the diff viewer used by vscode. this is obviously very actively maintained and quite polished, and migrating would also remove a dependency which is always nice. we should migrate to it when we can.
The text was updated successfully, but these errors were encountered: