Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate diff viewer to use monaco's diff viewer #2275

Closed
bcolloran opened this issue Sep 19, 2019 · 2 comments
Closed

migrate diff viewer to use monaco's diff viewer #2275

bcolloran opened this issue Sep 19, 2019 · 2 comments

Comments

@bcolloran
Copy link
Contributor

monaco editor comes with the diff viewer used by vscode. this is obviously very actively maintained and quite polished, and migrating would also remove a dependency which is always nice. we should migrate to it when we can.

@bcolloran
Copy link
Contributor Author

bcolloran commented Sep 19, 2019

little more on this: i'm not sure how involved this will be; it might be tricky or it might be pretty easy.

we'd need to create a custom component to instantiate the monaco diff viewer, along the lines of the editor component but i think waaaay simpler since the state updating would not need to be so sophisticated -- i think we could write it as it's own component that could just take the same props as ReactDiffViewer and have it be a drop-in replacement, but i'm not 100% sure.

@wlach
Copy link
Contributor

wlach commented Sep 19, 2019

FWIW, our usage of react-diff-viewer is very very simple (as is the component):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants