-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Serve iframe from django + resurrect iodide local-only dev environment #2024
Conversation
1d086c0
to
54a220a
Compare
54a220a
to
febd017
Compare
@bcolloran please review js parts (python portions optional) |
I don't see anything I'd be concerned about off the top of my head. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All seems to work as desired in the django + npm run start
mode.
in simple-serve
mode, there seems to be a port mismatch somewhere -- i'm getting:
Failed to execute ‘postMessage’ on ‘DOMWindow’: The target origin provided (‘http://localhost:8000’) does not match the recipient window’s origin (‘http://localhost:8080’).
,
and the eval-frame is not loading. for simple-serve, you might still need to tweak IODIDE_EVAL_FRAME_ORIGIN
and IODIDE_EDITOR_ORIGIN
in webpack or something like that?
(oh also: there aren't really an JS changes yet in this -- i expect you have other stuff coming in follow-up) |
@bcolloran the port issue comes from the fact that currently webpack is picking up some stuff from .env, where we had specified these values with our dockerflow-based environment in mind. Oops. For now I'll address this by just serving from port 8000 again, as we do for the internal server -- we can change this later after I move to the next phase of this work, which is to stop specifying server names inside our webpack-generated js altogether. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sounds good, thanks will
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty straightforward to me, +1.
107d5e2
to
5012b8f
Compare
This will allow us to swap in metadata used by the eval frame on the server side, without recompiling the webpack assets. It is a necessary prerequisite for iodide-project#1943 ("Iodide should not hardcode server assets").
For testing changes to the editor only, you can now use the (renamed) "simple-serve" command.
5012b8f
to
5d96dea
Compare
/notebooks/eval-frame/
endpoint. This is architecturally a little cleaner and paves the way towards Iodide should not hardcode server addresses #1943"simple-serve" command.
Pull Request checklist