deprecate the "environment" api and related code #2038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcolloran
commented
Jul 16, 2019
| {noVariables} | ||
| {edvElem} | ||
| {declaredVariables} | ||
| <div className="declared-variables-list"> |
There was a problem hiding this comment.
turns out we don't need any of the conditionals removed from above, b/c the declared variables pane will now always show at least iodide in the user variable explorer.
bcolloran
commented
Jul 16, 2019
| @@ -1,5 +1,5 @@ | |||
| .side-pane { | |||
| width:auto !important; | |||
| width: auto !important; | |||
There was a problem hiding this comment.
i just cut a few things from this file, but prettier made a ton of changes :-/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@hamilton this touches quite a few files actually, but should be quick to check. QA is easy -- just run any code and verify that the declared vars pane works as expected
Pull Request checklist