Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server authentication docs #2091

Merged
merged 4 commits into from
Aug 9, 2019

Conversation

wlach
Copy link
Contributor

@wlach wlach commented Jul 26, 2019

Adding some documentation on how Iodide's authentication system works, both for future reference and to support an RRA into the details of the internal iodide server. Please let me know if something is unclear or missing.

(no rush on review as I'll be out all next week)

Pull Request checklist

  • Documentation: If this feature has or requires documentation, the relevant docs have been updated.
  • Changelog: This PR updates the changelog with any user-visible changes.
  • [N/A] Tests: This PR includes thorough tests or an explanation of why it does not

@wlach wlach requested review from jezdez and robotblake July 26, 2019 19:56
@wlach wlach force-pushed the server-authentication-docs branch from 69a325b to 61f2e95 Compare July 26, 2019 20:02
Copy link
Contributor

@robotblake robotblake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good to me 👍

@wlach
Copy link
Contributor Author

wlach commented Aug 9, 2019

I'm going to go ahead and merge this, we can always incorporate additional feedback later.

@wlach wlach merged commit 2f92b5f into iodide-project:master Aug 9, 2019
@wlach wlach deleted the server-authentication-docs branch August 9, 2019 16:53
@jezdez
Copy link
Contributor

jezdez commented Aug 15, 2019

FWIW I got to finally look at this and this looked all good. Thanks @wlach!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants