-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Escape IOMD files (fixes #1416) #2193
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, thank you! I have some nits but the implementation looks technically correct.
BTW, yes, this change seems worth mentioning in the changelog! Please add an entry. |
Turns out I completely forgot about the preview window on the right and the script in |
Actually thinking about it more, I don't think script tags were ever truly supported as part of md cells. I am not sure if we should ever allow them -- possibly not. For now I'd say we can merge this as-is, assuming it works (haven't tested it yet). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested this, it works well! Thank you so much for this PR. I'm not sure how much time or where your exact interests with iodide are, but if you're looking for something on the frontend which might be an incremental step up in difficulty from this one, maybe try: #2175
Thanks for the review @wlach! Don't have a specific goal in mind, just want to help build out the next great programming environment :-) Jokes aside, I would be happy and excited to take a look at #2175 although since iodide is completely weekend and nights for me can't promise a timeline. I might also look into compiling some libraries with pyodide and write some notebooks and I'll let you know if I went into that rabbit hole so someone else could take that issue. |
Also FWIW preview rendering seems to be working if I add |
Sorry for the turnaround time!
This fixes #1416 by:
Tests have been added to reflect the changes. This is kind of use visible but is a bit of an edge case so will update CHANGELOG.md if you think it's warranted.
LMK if there's a better approach!
Pull Request checklist