upgrade to emotion 10 / refactor to accomodate the new API #2244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
wlach
suggested changes
Sep 13, 2019
wlach
approved these changes
Sep 13, 2019
|
thanks for tackling this @hamilton! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request checklist
This PR effectively does what #1795 hints at – to actually upgrade to Emotion v10, we have to use the new namespacing, install the additional packages, and remove the deprecated
cssfunctionality where relevant. This PR does all that.There are a lot of files that don't need to be reviewed. I would just check to see that nothing looks out of the ordinary via manual testing, and perhaps check
package.jsonto see if there was anything I missed (I took a look myself but I think it's fine).fwiw, this does not fix all the warnings in the client, but it does look like it boils it down to one, vs. the 4-5 from before.
Probably only need 1 of y'all to review this one.