Fix coloring of History Modal title #2301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wlach
suggested changes
Sep 27, 2019
There was a problem hiding this comment.
Thanks for tracking this down. :) I think the solution is a little suboptimal as it inlines the style-- let's try using the !important flag to make sure that our declaration of color overrides the material UI one.
I tried doing this with the dev console and it seemed to work:
Co-Authored-By: William Lachance <wrlach@gmail.com>
This change made the pull request in lines with rest of the codebase, thanks! |
wlach
approved these changes
Sep 27, 2019
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request attempts to fix coloring of typography in the title of history modal. Using
styled, it appeared black, not utilizing thecolor: #fffgiven to it. When the style is directly applied using astyle={{ color: #fff }}, the title is white as desired.