Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend Python test harness. #2305

Merged
merged 5 commits into from
Sep 27, 2019
Merged

Extend Python test harness. #2305

merged 5 commits into from
Sep 27, 2019

Conversation

jezdez
Copy link
Contributor

@jezdez jezdez commented Sep 27, 2019

Originally part of #2219 but then extracted out to simplify review there.

As requested in #2219 (comment).

  • add a few default pytest parameters that I use often
  • add flake8 linting
  • add coverage linting
  • add isort linting
  • add ability to disable flake8, coverage, isort with new --lean parameter for pytest
  • add staticfiles pytest plugin
  • restructure tests directory a bit to stop requiring sys.path modification
  • fix a warning that showed up because of freezegun

Pull Request checklist

  • Documentation: If this feature has or requires documentation, the relevant docs have been updated.
  • Changelog: This PR updates the changelog with any user-visible changes.
  • Tests: This PR includes thorough tests or an explanation of why it does not

- add a few default pytest parameters that I use often
- add flake8 linting
- add coverage linting
- add isort linting
- add ability to disable flake8, coverage, isort with new --lean parameter for pytest
- add staticfiles pytest plugin
- restructure tests directory a bit to stop requiring sys.path modification
- fix a warning that showed up because of freezegun
@jezdez jezdez requested a review from wlach September 27, 2019 15:45
Copy link
Contributor

@wlach wlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm minus some minor nits!

jezdez and others added 2 commits September 27, 2019 21:20
Co-Authored-By: William Lachance <wlachance@mozilla.com>
@wlach wlach merged commit dcc3d5d into master Sep 27, 2019
@wlach wlach deleted the test-extensions branch September 27, 2019 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants