Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase max length of file source urls from 200 to 8192 #2314

Merged

Conversation

wlach
Copy link
Contributor

@wlach wlach commented Sep 30, 2019

Some URLs that people use can get quite long, so best to increase
the max amount here.

This can affect long bugzilla queries, like those used by @teonbrooks on itmo.

Pull Request checklist

  • [N/A] Documentation: If this feature has or requires documentation, the relevant docs have been updated.
  • Changelog: This PR updates the changelog with any user-visible changes.
  • [N/A] Tests: This PR includes thorough tests or an explanation of why it does not

@wlach wlach requested a review from jezdez September 30, 2019 19:37
@wlach wlach force-pushed the increase-max-file-source-url-length branch from d76f0e7 to 9d58855 Compare September 30, 2019 19:44
Copy link
Contributor

@jezdez jezdez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I think this requires a new migration, right?

@wlach
Copy link
Contributor Author

wlach commented Sep 30, 2019

LGTM, but I think this requires a new migration, right?

Totally does, I forgot to add it! Thanks for checking

Some URLs that people use can get quite long, so best to increase
the max amount here.
@wlach wlach force-pushed the increase-max-file-source-url-length branch from 9d58855 to bbc4bb0 Compare September 30, 2019 21:26
@wlach wlach merged commit 125a1fe into iodide-project:master Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants