Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch from react-helmet to react-helmet-async #2315

Merged
merged 2 commits into from
Sep 30, 2019
Merged

Switch from react-helmet to react-helmet-async #2315

merged 2 commits into from
Sep 30, 2019

Conversation

wlach
Copy link
Contributor

@wlach wlach commented Sep 30, 2019

Fixes a console error by implicitly removing the dependency on react-side-effect
(see nfl/react-helmet#465).

Pull Request checklist

  • [N/A] Documentation: If this feature has or requires documentation, the relevant docs have been updated.
  • Changelog: This PR updates the changelog with any user-visible changes.
  • [N/A] Tests: This PR includes thorough tests or an explanation of why it does not

@wlach
Switch from react-helmet to react-helmet-async
6680163 
Fixes a console error by implicitly removing the dependency on react-side-effect
(see nfl/react-helmet#465).
@wlach wlach requested a review from hamilton September 30, 2019 21:11
@bcolloran
Copy link
Contributor

lgtm, thanks @wlach

@bcolloran
Copy link
Contributor

(merge when you wish)

@wlach wlach merged commit 65fb653 into iodide-project:master Sep 30, 2019
@wlach wlach deleted the react-helmet-async branch September 30, 2019 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hamilton hamilton Awaiting requested review from hamilton

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wlach @bcolloran @rogeriorioli