Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collect email addresses from github #2329

Merged

Conversation

wlach
Copy link
Contributor

@wlach wlach commented Oct 3, 2019

This will let us reach out more easily to people who log into
alpha.iodide.io. Standard Mozilla privacy policy still applies
and GitHub will ensure that people consent to this.

Pull Request checklist

  • [N/A] Documentation: If this feature has or requires documentation, the relevant docs have been updated.
  • Changelog: This PR updates the changelog with any user-visible changes.
  • [N/A] Tests: This PR includes thorough tests or an explanation of why it does not

@bcolloran
Copy link
Contributor

thanks Will 👍

@wlach
Copy link
Contributor Author

wlach commented Oct 3, 2019

Image of github permissions dialog:

image

@wlach wlach requested a review from bcolloran October 3, 2019 20:09
@codecov
Copy link

codecov bot commented Oct 3, 2019

Codecov Report

Merging #2329 into master will decrease coverage by 9.92%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2329      +/-   ##
==========================================
- Coverage   69.35%   59.42%   -9.93%     
==========================================
  Files         220      168      -52     
  Lines        5335     3707    -1628     
  Branches      854      736     -118     
==========================================
- Hits         3700     2203    -1497     
+ Misses       1606     1504     -102     
+ Partials       29        0      -29
Impacted Files Coverage Δ
server/openidc/tests/test_middleware.py
server/notebooks/urls.py
server/tests/test_settings.py
server/tests/test_token_authentication.py
server/notebooks/apps.py
server/notebooks/views.py
server/notebooks/api_views.py
server/notebooks/api_urls.py
server/celery.py
server/notebooks/middleware.py
... and 41 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82c8a3f...e84326b. Read the comment docs.

This will let us reach out more easily to people who log into
alpha.iodide.io. Standard Mozilla privacy policy still applies
and GitHub will ensure that people consent to this.
@wlach wlach force-pushed the collect-emails-from-github-logins branch from 39a7e4c to e84326b Compare October 3, 2019 20:23
@wlach wlach mentioned this pull request Oct 3, 2019
@wlach
Copy link
Contributor Author

wlach commented Oct 3, 2019

test-server is failing due to an issue unrelated to this PR: #2330

@wlach wlach merged commit 96eac86 into iodide-project:master Oct 3, 2019
@wlach wlach deleted the collect-emails-from-github-logins branch October 3, 2019 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants