-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move to Spinach. #2381
Move to Spinach. #2381
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2381 +/- ##
==========================================
- Coverage 69.74% 69.51% -0.24%
==========================================
Files 224 223 -1
Lines 5537 5451 -86
Branches 884 877 -7
==========================================
- Hits 3862 3789 -73
+ Misses 1650 1643 -7
+ Partials 25 19 -6
|
@jezdez CI seems to be failing on this one... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will take a closer look when unit tests passing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this out and it works great. LGTM w/ comments addressed. Thanks so much for doing this! Also, could you squash this PR and give it a title like "Use Spinach task scheduler instead of Celery"?
Co-Authored-By: William Lachance <wlachance@mozilla.com>
@wlach Would you mind looking at Heroku and see if the scheduler dyno is disabled correctly? |
Yup, it's gone! |
Pull Request checklist