Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to Spinach. #2381

Merged
merged 5 commits into from
Oct 29, 2019
Merged

Move to Spinach. #2381

merged 5 commits into from
Oct 29, 2019

Conversation

jezdez
Copy link
Contributor

@jezdez jezdez commented Oct 22, 2019

Pull Request checklist

  • Documentation: If this feature has or requires documentation, the relevant docs have been updated.
  • Changelog: This PR updates the changelog with any user-visible changes.
  • Tests: This PR includes thorough tests or an explanation of why it does not

@jezdez jezdez requested a review from wlach October 22, 2019 17:14
@codecov
Copy link

codecov bot commented Oct 22, 2019

Codecov Report

Merging #2381 into master will decrease coverage by 0.23%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2381      +/-   ##
==========================================
- Coverage   69.74%   69.51%   -0.24%     
==========================================
  Files         224      223       -1     
  Lines        5537     5451      -86     
  Branches      884      877       -7     
==========================================
- Hits         3862     3789      -73     
+ Misses       1650     1643       -7     
+ Partials       25       19       -6
Impacted Files Coverage Δ
server/tests/test_file_update_operations.py 100% <100%> (ø) ⬆️
server/tests/settings.py 100% <100%> (ø)
server/files/tasks.py 100% <100%> (ø) ⬆️
server/files/api_views.py 85.71% <100%> (ø) ⬆️

@wlach
Copy link
Contributor

wlach commented Oct 22, 2019

@jezdez CI seems to be failing on this one...

Copy link
Contributor

@wlach wlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will take a closer look when unit tests passing

@jezdez jezdez requested a review from wlach October 28, 2019 14:40
Copy link
Contributor

@wlach wlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this out and it works great. LGTM w/ comments addressed. Thanks so much for doing this! Also, could you squash this PR and give it a title like "Use Spinach task scheduler instead of Celery"?

jezdez and others added 2 commits October 29, 2019 13:33
Co-Authored-By: William Lachance <wlachance@mozilla.com>
@jezdez jezdez merged commit 1891a59 into master Oct 29, 2019
@jezdez jezdez deleted the spinach branch October 29, 2019 13:41
@jezdez
Copy link
Contributor Author

jezdez commented Oct 29, 2019

@wlach Would you mind looking at Heroku and see if the scheduler dyno is disabled correctly?

@wlach
Copy link
Contributor

wlach commented Oct 29, 2019

@wlach Would you mind looking at Heroku and see if the scheduler dyno is disabled correctly?

Yup, it's gone!

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants