Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reps errors on proxies #2395

Merged
merged 2 commits into from
Oct 29, 2019
Merged

Fix reps errors on proxies #2395

merged 2 commits into from
Oct 29, 2019

Conversation

bcolloran
Copy link
Contributor

Pull Request checklist

  • Documentation: N/A
  • [ x ] Changelog:
  • [ x ] Tests:

@bcolloran bcolloran changed the title Fix pyodide reps error Fix reps errors on proxies Oct 29, 2019
@codecov
Copy link

codecov bot commented Oct 29, 2019

Codecov Report

Merging #2395 into master will increase coverage by 9.96%.
The diff coverage is 65%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2395      +/-   ##
==========================================
+ Coverage   59.78%   69.74%   +9.96%     
==========================================
  Files         172      224      +52     
  Lines        3819     5537    +1718     
  Branches      763      884     +121     
==========================================
+ Hits         2283     3862    +1579     
- Misses       1536     1650     +114     
- Partials        0       25      +25
Impacted Files Coverage Δ
src/reps/shared/type-categories.js 100% <100%> (ø) ⬆️
src/reps/__test_helpers__/reps-test-value-cases.js 67.44% <52%> (-3.99%) ⬇️
src/reps/serialization/value-summary-serializer.js 94.23% <85.71%> (+0.61%) ⬆️
server/openidc/tests/test_middleware.py 100% <0%> (ø)
server/notebooks/urls.py 100% <0%> (ø)
server/tests/test_settings.py 100% <0%> (ø)
server/tests/test_token_authentication.py 100% <0%> (ø)
server/notebooks/apps.py 0% <0%> (ø)
server/notebooks/views.py 86.95% <0%> (ø)
server/notebooks/api_views.py 98.91% <0%> (ø)
... and 45 more

@bcolloran bcolloran merged commit e6f90f1 into master Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant