Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing layout content #6

Closed
sebbaum opened this issue Mar 4, 2019 · 0 comments
Assignees
Labels
bug
Projects

Comments

@sebbaum
Copy link
Contributor

@sebbaum sebbaum commented Mar 4, 2019

Describe the bug
If a pattern contains @extends('layouts.app') the rendered output in the main project is missing the content of the layout/app.blade.php file.

To Reproduce
Steps to reproduce the behavior:

  1. Create a new Pattern e.g. pages.homepage
  2. Add a route to render this pattern
  3. Call the route in your browser
  4. The rendered page is not styled. The layout file's content is missing

Expected behavior
The page is rendered as if an @include directive is used.

Additional context
The bug is gone, if the call to $this->evaluatePatternStatus($pattern); in PatternServiceProvider::parse() is removed.

@sebbaum sebbaum added the bug label Mar 4, 2019
@sebbaum sebbaum self-assigned this Mar 4, 2019
@sebbaum sebbaum added this to BACKLOG in bugs&issues via automation Mar 4, 2019
@sebbaum sebbaum moved this from BACKLOG to IN PROGRESS in bugs&issues Mar 4, 2019
sebbaum added a commit that referenced this issue Mar 5, 2019
- renaming
- finally fixes #6
@sebbaum sebbaum closed this in 06d9ce7 Mar 5, 2019
bugs&issues automation moved this from IN PROGRESS to TESTING Mar 5, 2019
@sebbaum sebbaum moved this from TESTING to DONE in bugs&issues Mar 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
bugs&issues
  
DONE
1 participant
You can’t perform that action at this time.