Fix PyPy/twisted incompatibility #35
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h the expected attrubutes of Code objects
Codecov Report
@@ Coverage Diff @@
## master #35 +/- ##
==========================================
+ Coverage 87.25% 88.17% +0.92%
==========================================
Files 4 4
Lines 204 203 -1
Branches 28 27 -1
==========================================
+ Hits 178 179 +1
+ Misses 16 15 -1
+ Partials 10 9 -1
Continue to review full report at Codecov.
|
|
Hmmm shouldn't there be some sort of backwards compatibility with old pickle format? Any particular reason you reverted bf15d92 ? |
|
Hi. I wasn't sure what the policy was w.r.t. backwards compatibility, or even if it was the appropriate way to handle backwards compatibility. Any thoughts? |
|
Just do a check like in bf15d92 - should be fine I guess. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR which fixes the issues described in #30. It adds a
co_codeattribute to theCodeclass, which allows TwistedFailureobjects to be created which expects theco_codeattribute to exist: https://github.com/twisted/twisted/blob/twisted-18.4.0/src/twisted/python/failure.py#L458I also updated the
.travisinstalled pypy versions to 6.0.0, for both Python 2 and 3.In order to make the build succeed, deprecated links in README.rst were updated.