chore(builder): update builders to work with ng9

[mhartington]

Updates cordova-serve builder to work with ng9/builders

[patrick-entinux]

I tried the code from the pull request and it seems that the new cordova-serve (aka livereload) is not compatible with @angular-builders/custom-webpack. Unfortunately my project is depending on some custom webpack settings so it could not compile successfully in this new mode.

I guess the executeDevServerBuilder() function runs the default Angular Dev Server Builder directly, but custom-webpack is doing some additional steps to load the custom webpack config before calling executeDevServerBuilder() internally.

https://github.com/just-jeb/angular-builders/blob/master/packages/custom-webpack/src/dev-server/index.ts.

So these steps are getting skipped now. Not sure if there is another API that can let both @ionic/angular-toolkit and @angular-builders/custom-webpack apply their custom webpack transforms.

[mhartington]

@patrick-entinux I looked into the custom webpack builder, and really, both are doing the same thing, extending the built-in builder running it.

I'm not 100% sure if there is anything we can do about that. Since both builders need to call the underlying target directly, executeDevServerBuilder, and there's no generic way to call that but still get the same functionality, I do not think both can be used here.

EDIT after talking with the ng-cli team, the best option would be to write your own builder that can combine what we do in our devserver and custom-webpack. Not ideal, but it would handle what you want.

[patrick-entinux]

@mhartington Thank you for looking into it and the recommendation. I will look into making a custom builder when I have time.

[mohamedsharaf]

@dwieeb pls review angular 9 released and ionic 5
merge and release new version

[dopplerDistortion]

any plans to release this PR ?

[mohamedsharaf]

release hope this fixes this problem
#214

[kyoz]

Yep. Hope this will soon be release. So i can enjoy ionic 5 with cordova plugins. Is there any issues blocked this PR from release ? ❤️

[mohamedsharaf]

you still can enjjoy ionic5 but angular 8.2

[Ionitron]

🎉 This PR is included in version 2.2.0 🎉

The release is available on:

• GitHub release
• npm package (@latest dist-tag)

Your semantic-release bot 📦🚀