Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(iOS): KV, Context fixes #83

Merged
merged 4 commits into from
Apr 16, 2024
Merged

fix(iOS): KV, Context fixes #83

merged 4 commits into from
Apr 16, 2024

Conversation

theproducer
Copy link
Collaborator

This PR fixes various issues on the iOS Engine:

  • KV: KV.get on an non-existent key returned an empty object instead of null
  • Fixed an issue within Runner that could potentially cause EXC_BAD_ACCESS crashes

Copy link

changeset-bot bot commented Apr 11, 2024

🦋 Changeset detected

Latest commit: 7df7a60

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@capacitor/background-runner Minor
ios-engine Minor
example-app Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@louis123562
Copy link

Sorry if this is not the ideal place for my notes; but i want you to know that with any version > 1.0.5 (e.g. 1.0.6-dev-20240409T144959.0 or 1.0.6-dev-20230915T160000.0) the CPU of the iOS-Device is always under pressure (high load) shortly after starting the app, even without dispatching any event.

Maybe you can have a look at that, too?

I am very excited for a new version :)

@theproducer
Copy link
Collaborator Author

Sorry if this is not the ideal place for my notes; but i want you to know that with any version > 1.0.5 (e.g. 1.0.6-dev-20240409T144959.0 or 1.0.6-dev-20230915T160000.0) the CPU of the iOS-Device is always under pressure (high load) shortly after starting the app, even without dispatching any event.

Maybe you can have a look at that, too?

I am very excited for a new version :)

Hello!

I would open a new issue with a test app that reproduces the issue (and preferably screenshots from Instruments showing CPU load).

If you have general questions, you can ping me in the Ionic Discord.

Copy link
Contributor

@markemer markemer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like the updates to `throws, LGTM

@theproducer theproducer merged commit 142e96d into main Apr 16, 2024
6 checks passed
@theproducer theproducer deleted the fix/ios-engine branch April 16, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants