Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: support deprecated types from Capacitor 2 #139

Merged
merged 33 commits into from
Dec 20, 2020
Merged

Conversation

imhoffd
Copy link
Contributor

@imhoffd imhoffd commented Dec 14, 2020

  • Export all definitions from each plugin
  • Rename types (and some enums) to remove the plugin's "prefix" (ref: Local Notifications #94 (comment))
  • Also rename types to be MethodNameOptions -> MethodNameResult where it makes sense
  • Re-export deprecated old names (checking core-plugin-definitions.ts for true v2 name)

@imhoffd imhoffd marked this pull request as ready for review December 15, 2020 21:18
Conflicts:
	action-sheet/package.json
	app-launcher/package.json
	app/README.md
	app/package.json
	browser/package.json
	clipboard/package.json
	device/README.md
	device/package.json
	dialog/package.json
	filesystem/package.json
	filesystem/src/definitions.ts
	haptics/package.json
	keyboard/package.json
	motion/README.md
	motion/package.json
	network/README.md
	network/package.json
	screen-reader/README.md
	screen-reader/package.json
	share/package.json
	status-bar/package.json
	storage/package.json
	text-zoom/package.json
	toast/package.json
@imhoffd imhoffd enabled auto-merge (squash) December 20, 2020 17:32
@imhoffd imhoffd merged commit 2d7127a into main Dec 20, 2020
@imhoffd imhoffd deleted the localize-types branch December 20, 2020 17:40
hmaretic24 pushed a commit to hmaretic24/capacitor-plugins that referenced this pull request Nov 9, 2022
* screen reader

* action sheet

* more screen reader

* wip

* export all from definitions

* motion

* toast

* haptics

* more screen reader

* app

* network

* app-launcher

* wip

* filesystem

* browser

* text-zoom

* status-bar

* device

* clipboard

* generate readmes

* fmt

* update docgen

* regen

* geolocation

* camera

* splash-screen

* build and format
hmaretic24 pushed a commit to hmaretic24/capacitor-plugins that referenced this pull request Apr 25, 2023
* screen reader

* action sheet

* more screen reader

* wip

* export all from definitions

* motion

* toast

* haptics

* more screen reader

* app

* network

* app-launcher

* wip

* filesystem

* browser

* text-zoom

* status-bar

* device

* clipboard

* generate readmes

* fmt

* update docgen

* regen

* geolocation

* camera

* splash-screen

* build and format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant