feat(geolocation): add interval option in watch position #1756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Toilal
force-pushed
the
geolocation-interval
branch
from
7585176
to
432c6d7
Compare
Toilal
commented
Aug 24, 2023
geolocation/src/definitions.ts
Outdated
| @@ -52,7 +52,7 @@ export interface GeolocationPlugin { | |||
| * @since 1.0.0 | |||
| */ | |||
| watchPosition( | |||
| options: PositionOptions, | |||
| options: WatchPositionOptions, | |||
There was a problem hiding this comment.
I'm not sure I need to add a new interface here.
There was a problem hiding this comment.
Not really, you can just add the new options to the existing interface.
Toilal
commented
Aug 24, 2023
| .setMaxUpdateDelayMillis(timeout) | ||
| .setMinUpdateIntervalMillis(5000) |
There was a problem hiding this comment.
This probably should be made another option along with interval, and have it default to 5000.
dallastjames
added
the
pr review requested
Toilal
force-pushed
the
geolocation-interval
branch
from
432c6d7
to
1d8240c
Compare
theproducer
requested changes
Sep 15, 2023
geolocation/android/src/main/java/com/capacitorjs/plugins/geolocation/GeolocationPlugin.java
Outdated
Show resolved
Hide resolved
| .setMaxUpdateDelayMillis(timeout) | ||
| .setMinUpdateIntervalMillis(5000) |
There was a problem hiding this comment.
This probably should be made another option along with interval, and have it default to 5000.
geolocation/src/definitions.ts
Outdated
| @@ -52,7 +52,7 @@ export interface GeolocationPlugin { | |||
| * @since 1.0.0 | |||
| */ | |||
| watchPosition( | |||
| options: PositionOptions, | |||
| options: WatchPositionOptions, | |||
There was a problem hiding this comment.
Not really, you can just add the new options to the existing interface.
Toilal
force-pushed
the
geolocation-interval
branch
from
1d8240c
to
33bcc06
Compare
Toilal
force-pushed
the
geolocation-interval
branch
2 times, most recently
from
1edf337
to
639daf3
Compare
|
I have just updated this pull request. |
Toilal
commented
Jan 11, 2024
| @@ -68,7 +68,7 @@ public void sendLocation(boolean enableHighAccuracy, final LocationResultCallbac | |||
| } | |||
|
|
|||
| @SuppressWarnings("MissingPermission") | |||
| public void requestLocationUpdates(boolean enableHighAccuracy, int timeout, final LocationResultCallback resultCallback) { | |||
| public void requestLocationUpdates(boolean enableHighAccuracy, long timeout, long interval, long minInterval, final LocationResultCallback resultCallback) { | |||
There was a problem hiding this comment.
Using long type seems to be better as LocationRequest.Builder accepts long arguments.
Toilal
commented
Jan 11, 2024
geolocation/android/src/main/java/com/capacitorjs/plugins/geolocation/GeolocationPlugin.java
Show resolved
Hide resolved
Toilal
force-pushed
the
geolocation-interval
branch
from
639daf3
to
74fc8a3
Compare
Toilal
force-pushed
the
geolocation-interval
branch
2 times, most recently
from
3da7c72
to
99c8958
Compare
Toilal
force-pushed
the
geolocation-interval
branch
from
99c8958
to
28375bc
Compare
|
Can i do anything to get this merged ? |
Toilal
force-pushed
the
geolocation-interval
branch
from
28375bc
to
d9bb366
Compare
Toilal
force-pushed
the
geolocation-interval
branch
from
d9bb366
to
dca1705
Compare
|
Hello, will this pull request be merged soon? |
Toilal
force-pushed
the
geolocation-interval
branch
from
dca1705
to
5fb2e57
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follow up #1619 and #1465