Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(local-notifications): add more info to pending notifications #211

Merged
merged 14 commits into from
Feb 5, 2021

Conversation

theproducer
Copy link
Contributor

This PR adds more useful information to the array of returned pending notification.

closes #193

@jcesarmobile
Copy link
Member

I think that instead of editing the LocalNotificationDescriptor type, they should return LocalNotificationSchema type. Not really sure if it’s worth it for schedule since it will just return what the user sent.
cancel should keep the LocalNotificationDescriptor with just the id, we can’t ask users to provide a full notification when we just need the id for canceling.

Joseph Pender added 6 commits January 28, 2021 16:29
# Conflicts:
#	local-notifications/android/src/main/java/com/capacitorjs/plugins/localnotifications/LocalNotification.java
#	local-notifications/ios/Plugin/LocalNotificationsPlugin.swift
#	local-notifications/src/web.ts
@theproducer theproducer merged commit 7c50487 into main Feb 5, 2021
@theproducer theproducer deleted the local-notifications-pending-details branch February 5, 2021 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants