fix(ios/android): better http error handling (#6208)

ionic-team · Jan 17, 2023 · 7d4d70a · 7d4d70a
1 parent 2d9f058
commit 7d4d70a
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/android/capacitor/src/main/java/com/getcapacitor/plugin/CapacitorHttp.java b/android/capacitor/src/main/java/com/getcapacitor/plugin/CapacitorHttp.java
@@ -34,8 +34,7 @@ public void run() {
                     JSObject response = HttpRequestHandler.request(call, httpMethod);
                     call.resolve(response);
                 } catch (Exception e) {
-                    System.out.println(e.toString());
-                    call.reject(e.getClass().getSimpleName(), e);
+                    call.reject(e.getLocalizedMessage(), e.getClass().getSimpleName(), e);
                 }
             }
         };

diff --git a/ios/Capacitor/Capacitor/Plugins/HttpRequestHandler.swift b/ios/Capacitor/Capacitor/Plugins/HttpRequestHandler.swift
@@ -170,7 +170,7 @@ class HttpRequestHandler {
             } catch {
                 // Explicitly reject if the http request body was not set successfully,
                 // so as to not send a known malformed request, and to provide the developer with additional context.
-                call.reject("Error", "REQUEST", error, [:])
+                call.reject(error.localizedDescription, (error as NSError).domain, error, nil)
                 return
             }
         }
@@ -180,7 +180,8 @@ class HttpRequestHandler {
         let task = urlSession.dataTask(with: urlRequest) { (data, response, error) in
             urlSession.invalidateAndCancel()
 
-            if error != nil {
+            if let error = error {
+                call.reject(error.localizedDescription, (error as NSError).domain, error, nil)
                 return
             }