Skip to content

Commit 8651ef1

Browse files
chore(cli): pin cli version instead of latest on plugin generation (#3201)
Co-authored-by: Dan Imhoff <dwieeb@gmail.com>
1 parent c2133c5 commit 8651ef1

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

cli/src/tasks/new-plugin.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -97,6 +97,7 @@ export async function newPlugin(config: Config) {
9797
const pluginPath = removeScope(answers.name);
9898
const domain = answers.domain;
9999
const className = answers.className;
100+
const cliVersion = config.cli.package.version;
100101

101102
if (await existsAsync(pluginPath)) {
102103
logFatal(`Directory ${pluginPath} already exists. Not overwriting.`);
@@ -112,7 +113,7 @@ export async function newPlugin(config: Config) {
112113
});
113114

114115
await runTask('Writing package.json', () => {
115-
return writePrettyJSON(join(pluginPath, 'package.json'), generatePackageJSON(answers));
116+
return writePrettyJSON(join(pluginPath, 'package.json'), generatePackageJSON(answers, cliVersion));
116117
});
117118

118119
await runTask('Installing NPM dependencies', async () => {
@@ -218,7 +219,7 @@ function generateAndroidManifest(domain: string, pluginPath: string) {
218219
`;
219220
}
220221

221-
function generatePackageJSON(answers: NewPluginAnswers) {
222+
function generatePackageJSON(answers: NewPluginAnswers, cliVersion: string) {
222223
return {
223224
name: answers.name,
224225
version: '0.0.1',
@@ -234,13 +235,13 @@ function generatePackageJSON(answers: NewPluginAnswers) {
234235
author: answers.author,
235236
license: answers.license,
236237
dependencies: {
237-
'@capacitor/core': 'latest'
238+
'@capacitor/core': `^${cliVersion}`
238239
},
239240
devDependencies: {
240241
'rimraf': '^3.0.0',
241242
'typescript': '^3.2.4',
242-
'@capacitor/ios': 'latest',
243-
'@capacitor/android': 'latest'
243+
'@capacitor/ios': `^${cliVersion}`,
244+
'@capacitor/android': `^${cliVersion}`
244245
},
245246
files: [
246247
'dist/',
@@ -270,4 +271,3 @@ function generatePackageJSON(answers: NewPluginAnswers) {
270271
}
271272
};
272273
}
273-

0 commit comments

Comments
 (0)