WIP feat(local-notifications): add Inbox and BigText Style for android #1513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a suggestion to use same behavior as cordova plugin to handle android InboxStyle and BigTextStyle. I would like to ask you, how do you would like to implement features like this and we will try to do the implementation. Or at least we'll try.
wslaghekke
reviewed
Oct 7, 2019
|
|
||
| } else { | ||
|
|
||
| mBuilder.setStyle(new NotificationCompat.BigTextStyle().bigText(localNotification.getBigText())); |
There was a problem hiding this comment.
CI is failing because of missing method localNotification.getBigText()
should it be the following?:
mBuilder.setStyle(new NotificationCompat.BigTextStyle().bigText(text));
|
@mburger81 Thanks for the PR! I think we'd rather lean towards explicit behavior. Additionally, we're about to begin work on Capacitor 3 which will involve a lot of refactoring, so let's wait on adding this functionality. Local and push notifications may exist separate from the Capacitor core in an official plugin. I created https://github.com/ionic-team/capacitor/issues/3178 to track this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a suggestion to use same behavior as cordova plugin to handle android InboxStyle and BigTextStyle.
I would like to ask you, how do you would like to implement features like this and we will try to do the implementation. Or at least we'll try.