Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if the device is online before checking for updates #154

Merged
merged 1 commit into from
Sep 26, 2018
Merged

Check if the device is online before checking for updates #154

merged 1 commit into from
Sep 26, 2018

Conversation

jcesarmobile
Copy link
Member

and throw and error if it is offline instead of making the API call that will fail anyway because it's offline.

@nphyatt nphyatt merged commit ddd7aa5 into ionic-team:master Sep 26, 2018
@jcesarmobile jcesarmobile deleted the check-offline branch September 26, 2018 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nphyatt nphyatt Awaiting requested review from nphyatt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jcesarmobile @nphyatt