Skip to content

Commit 16a0111

Browse files
committed
fix(cordova): ng should ignore separated args for Cordova build
fixes #3602
1 parent 63b0eef commit 16a0111

File tree

2 files changed

+10
-2
lines changed

2 files changed

+10
-2
lines changed

packages/ionic/src/lib/project/angular/build.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -111,16 +111,20 @@ class AngularBuildCLI extends BuildCLI<AngularBuildOptions> {
111111
'cordova-assets': options.cordovaAssets !== false ? undefined : 'false',
112112
};
113113

114+
let separatedArgs = options['--'];
115+
114116
if (options.engine === 'cordova') {
115117
const integration = await this.e.project.getIntegration('cordova');
116118
args.platform = options.platform;
117119

118120
if (this.e.project.directory !== integration.root) {
119121
args.cordovaBasePath = integration.root;
120122
}
123+
124+
separatedArgs = [];
121125
}
122126

123-
return [...unparseArgs(args), ...options['--']];
127+
return [...unparseArgs(args), ...separatedArgs];
124128
}
125129

126130
protected buildArchitectCommand(options: AngularBuildOptions): string[] {

packages/ionic/src/lib/project/angular/serve.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -142,16 +142,20 @@ export class AngularServeCLI extends ServeCLI<AngularServeOptions> {
142142
'source-map': options.sourcemaps !== false ? options.sourcemaps : 'false',
143143
};
144144

145+
let separatedArgs = options['--'];
146+
145147
if (options.engine === 'cordova') {
146148
const integration = await this.e.project.getIntegration('cordova');
147149
args.platform = options.platform;
148150

149151
if (this.e.project.directory !== integration.root) {
150152
args.cordovaBasePath = integration.root;
151153
}
154+
155+
separatedArgs = [];
152156
}
153157

154-
return [...unparseArgs(args), ...options['--']];
158+
return [...unparseArgs(args), ...separatedArgs];
155159
}
156160

157161
protected buildArchitectCommand(options: AngularServeOptions): string[] {

0 commit comments

Comments
 (0)