Skip to content

Commit 2480a01

Browse files
committed
feat(capacitor): unlock capacitor commands as beta
1 parent 62a2918 commit 2480a01

File tree

9 files changed

+14
-14
lines changed

9 files changed

+14
-14
lines changed

packages/@ionic/cli-utils/src/definitions.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -344,7 +344,7 @@ export interface ITelemetry {
344344

345345
export type NpmClient = 'yarn' | 'npm';
346346

347-
export type FeatureId = 'capacitor-commands' | 'ssl-commands';
347+
export type FeatureId = 'ssl-commands';
348348

349349
export interface ConfigFile {
350350
'version': string;
@@ -370,7 +370,6 @@ export interface ConfigFile {
370370
'tokens.telemetry'?: string;
371371

372372
// Features
373-
'features.capacitor-commands'?: boolean;
374373
'features.ssl-commands'?: boolean;
375374
}
376375

packages/@ionic/cli-utils/src/lib/config.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,6 @@ export class Config extends BaseConfig<ConfigFile> implements IConfig {
7474
'git.setup': c.git && c.git.setup,
7575
'tokens.user': c.tokens && c.tokens.user,
7676
'tokens.telemetry': c.tokens && c.tokens.telemetry,
77-
'features.capacitor-commands': c.features && c.features['capacitor-commands'],
7877
'features.ssl-commands': c.features && c.features['ssl-commands'],
7978
};
8079
}

packages/ionic/src/commands/capacitor/add.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import chalk from 'chalk';
22

3-
import { validators } from '@ionic/cli-framework';
3+
import { CommandGroup, validators } from '@ionic/cli-framework';
44
import { CommandInstanceInfo, CommandLineInputs, CommandLineOptions, CommandMetadata, CommandPreRun } from '@ionic/cli-utils';
55

66
import { CapacitorCommand } from './base';
@@ -22,6 +22,7 @@ ${chalk.green('ionic capacitor add')} will do the following:
2222
validators: [validators.required],
2323
},
2424
],
25+
groups: [CommandGroup.Beta],
2526
};
2627
}
2728

packages/ionic/src/commands/capacitor/copy.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
import chalk from 'chalk';
22

3+
import { CommandGroup } from '@ionic/cli-framework';
34
import { CommandInstanceInfo, CommandLineInputs, CommandLineOptions, CommandMetadata, CommandPreRun } from '@ionic/cli-utils';
45

56
import { CapacitorCommand } from './base';
@@ -20,6 +21,7 @@ ${chalk.green('ionic capacitor copy')} will do the following:
2021
summary: `The platform to copy (e.g. ${['android', 'ios', 'electron'].map(v => chalk.green(v)).join(', ')})`,
2122
},
2223
],
24+
groups: [CommandGroup.Beta],
2325
};
2426
}
2527

packages/ionic/src/commands/capacitor/index.ts

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -5,12 +5,6 @@ import { CommandMap, Namespace } from '@ionic/cli-utils/lib/namespace';
55

66
export class CapacitorNamespace extends Namespace {
77
async getMetadata() {
8-
const groups: string[] = [NamespaceGroup.Beta];
9-
10-
if (!this.env.config.get('features.capacitor-commands')) {
11-
groups.push(NamespaceGroup.Hidden);
12-
}
13-
148
return {
159
name: 'capacitor',
1610
summary: 'Capacitor functionality',
@@ -20,7 +14,7 @@ These commands integrate with Capacitor, Ionic's new native layer project which
2014
Learn more about Capacitor:
2115
- Main documentation: ${chalk.bold('https://capacitor.ionicframework.com/')}
2216
`,
23-
groups,
17+
groups: [NamespaceGroup.Beta],
2418
};
2519
}
2620

packages/ionic/src/commands/capacitor/open.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import chalk from 'chalk';
22

3-
import { validators } from '@ionic/cli-framework';
3+
import { CommandGroup, validators } from '@ionic/cli-framework';
44
import { CommandInstanceInfo, CommandLineInputs, CommandLineOptions, CommandMetadata, CommandPreRun } from '@ionic/cli-utils';
55

66
import { CapacitorCommand } from './base';
@@ -22,6 +22,7 @@ ${chalk.green('ionic capacitor open')} will do the following:
2222
validators: [validators.required],
2323
},
2424
],
25+
groups: [CommandGroup.Beta],
2526
};
2627
}
2728

packages/ionic/src/commands/capacitor/run.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import chalk from 'chalk';
22
import * as path from 'path';
33

4-
import { validators } from '@ionic/cli-framework';
4+
import { CommandGroup, validators } from '@ionic/cli-framework';
55
import { onBeforeExit, sleepForever } from '@ionic/cli-framework/utils/process';
66
import { CommandInstanceInfo, CommandLineInputs, CommandLineOptions, CommandMetadata, CommandMetadataOption, CommandPreRun } from '@ionic/cli-utils';
77
import { build } from '@ionic/cli-utils/lib/build';
@@ -14,7 +14,7 @@ import { CapacitorCommand } from './base';
1414

1515
export class RunCommand extends CapacitorCommand implements CommandPreRun {
1616
async getMetadata(): Promise<CommandMetadata> {
17-
let groups: string[] = [];
17+
let groups: string[] = [CommandGroup.Beta];
1818
const options: CommandMetadataOption[] = [
1919
// Build Options
2020
{

packages/ionic/src/commands/capacitor/sync.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
import chalk from 'chalk';
22

3+
import { CommandGroup } from '@ionic/cli-framework';
34
import { CommandInstanceInfo, CommandLineInputs, CommandLineOptions, CommandMetadata, CommandPreRun } from '@ionic/cli-utils';
45

56
import { CapacitorCommand } from './base';
@@ -22,6 +23,7 @@ ${chalk.green('ionic capacitor sync')} will do the following:
2223
summary: `The platform to sync (e.g. ${['android', 'ios', 'electron'].map(v => chalk.green(v)).join(', ')})`,
2324
},
2425
],
26+
groups: [CommandGroup.Beta],
2527
};
2628
}
2729

packages/ionic/src/commands/capacitor/update.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
import chalk from 'chalk';
22

3+
import { CommandGroup } from '@ionic/cli-framework';
34
import { CommandInstanceInfo, CommandLineInputs, CommandLineOptions, CommandMetadata, CommandPreRun } from '@ionic/cli-utils';
45

56
import { CapacitorCommand } from './base';
@@ -21,6 +22,7 @@ ${chalk.green('ionic capacitor update')} will do the following:
2122
summary: `The platform to update (e.g. ${['android', 'ios', 'electron'].map(v => chalk.green(v)).join(', ')})`,
2223
},
2324
],
25+
groups: [CommandGroup.Beta],
2426
};
2527
}
2628

0 commit comments

Comments
 (0)