Skip to content

Commit 5ad11ef

Browse files
committed
chore(serve): --devapp required for DevApp
BREAKING CHANGE: For DevApp usage, the `--devapp` flag is now required for all project types, instead of being automatic. This change was made in conjunction with changing the default host from `0.0.0.0` to `localhost`. By explicitly specifying `--devapp`, however, `0.0.0.0` is used if `--address` is not specified.
1 parent d2a32de commit 5ad11ef

File tree

4 files changed

+7
-21
lines changed

4 files changed

+7
-21
lines changed

packages/ionic/src/lib/project/angular/serve.ts

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -82,13 +82,6 @@ The dev server can use HTTPS via the ${input('--ssl')} option ${chalk.bold.red('
8282
groups: [MetadataGroup.ADVANCED, 'cordova'],
8383
hint: weak('[ng]'),
8484
},
85-
{
86-
name: 'devapp',
87-
summary: 'Publish DevApp service',
88-
type: Boolean,
89-
default: false,
90-
groups: [MetadataGroup.ADVANCED],
91-
},
9285
],
9386
exampleCommands: [
9487
'-- --proxy-config proxy.conf.json',

packages/ionic/src/lib/project/ionic-angular/serve.ts

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -43,13 +43,6 @@ export class IonicAngularServeRunner extends ServeRunner<IonicAngularServeOption
4343
groups: [MetadataGroup.HIDDEN, 'cordova'],
4444
hint: weak('[app-scripts]'),
4545
},
46-
{
47-
name: 'devapp',
48-
summary: 'Do not publish DevApp service',
49-
type: Boolean,
50-
default: true,
51-
groups: [MetadataGroup.ADVANCED],
52-
},
5346
{
5447
name: 'livereload-port',
5548
summary: 'Use specific port for live-reload',

packages/ionic/src/lib/project/ionic1/serve.ts

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -48,13 +48,6 @@ export class Ionic1ServeRunner extends ServeRunner<Ionic1ServeOptions> {
4848
groups: [MetadataGroup.ADVANCED, 'cordova'],
4949
spec: { value: 'port' },
5050
},
51-
{
52-
name: 'devapp',
53-
summary: 'Do not publish DevApp service',
54-
type: Boolean,
55-
default: true,
56-
groups: [MetadataGroup.ADVANCED],
57-
},
5851
{
5952
name: 'proxy',
6053
summary: 'Do not add proxies',

packages/ionic/src/lib/serve.ts

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,13 @@ export const COMMON_SERVE_COMMAND_OPTIONS: ReadonlyArray<CommandMetadataOption>
7171
summary: `Target platform on chosen engine (e.g. ${['ios', 'android'].map(e => input(e)).join(', ')})`,
7272
groups: [MetadataGroup.HIDDEN, MetadataGroup.ADVANCED],
7373
},
74+
{
75+
name: 'devapp',
76+
summary: 'Publish DevApp service',
77+
type: Boolean,
78+
default: false,
79+
groups: [MetadataGroup.ADVANCED],
80+
},
7481
];
7582

7683
export interface ServeRunnerDeps {

0 commit comments

Comments
 (0)