Skip to content

Commit bf10674

Browse files
rdlaboimhoffd
authored andcommitted
fix(serve): await connectivity on specified host, not localhost (#3444)
1 parent f767bfb commit bf10674

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

packages/@ionic/cli-utils/src/lib/project/angular/serve.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ ${chalk.cyan('[1]')}: ${chalk.bold('https://github.com/angular/angular-cli/wiki/
104104
this.e.log.info(`Waiting for connectivity with ${chalk.green(program)}...`);
105105
}, 5000);
106106

107-
await isHostConnectable('localhost', ngPort);
107+
await isHostConnectable(options.address, ngPort);
108108
clearInterval(interval);
109109

110110
return {

packages/@ionic/cli-utils/src/lib/project/ionic-angular/serve.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,7 @@ export class IonicAngularServeRunner extends ServeRunner<IonicAngularServeOption
126126
this.e.log.info(`Waiting for connectivity with ${chalk.green(program)}...`);
127127
}, 5000);
128128

129-
await isHostConnectable('localhost', port);
129+
await isHostConnectable(options.address, port);
130130
clearInterval(interval);
131131

132132
return {

packages/@ionic/cli-utils/src/lib/project/ionic1/serve.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,7 @@ export class Ionic1ServeRunner extends ServeRunner<Ionic1ServeOptions> {
105105
this.e.log.info(`Waiting for connectivity with ${chalk.green(program)}...`);
106106
}, 5000);
107107

108-
await isHostConnectable('localhost', port);
108+
await isHostConnectable(options.address, port);
109109
clearInterval(interval);
110110

111111
return {

0 commit comments

Comments
 (0)