feat(cordova): handle lack of port forwarding in ios

We still default --address to localhost, even for Cordova, but we warn
about the potential issue running on iOS hardware devices.

Author: imhoffd

packages/ionic/src/lib/build.ts

@@ -81,6 +81,8 @@ export abstract class BuildRunner<T extends BuildOptions<any>> implements Runner
   }
 
   async run(options: T): Promise<void> {
+    debug('build options: %O', options);
+
     if (options.engine === 'cordova' && !options.platform) {
       this.e.log.warn(`Cordova engine chosen without a target platform. This could cause issues. Please use the ${input('--platform')} option.`);
     }

packages/ionic/src/lib/integrations/cordova/utils.ts

@@ -42,16 +42,21 @@ export function filterArgumentsForCordova(metadata: CommandMetadata, options: Co
 }
 
 export function generateOptionsForCordovaBuild(metadata: CommandMetadata, inputs: CommandLineInputs, options: CommandLineOptions): CommandLineOptions {
-  const [ platform ] = inputs;
+  const platform = inputs[0] ? inputs[0] : (options['platform'] ? String(options['platform']) : undefined);
+
+  // iOS does not support port forwarding out-of-the-box like Android does.
+  // See https://github.com/ionic-team/native-run/issues/20
+  const externalAddressRequired = platform === 'ios' || !options['native-run'];
+
   const includesAppScriptsGroup = OptionFilters.includesGroups('app-scripts');
   const excludesCordovaGroup = OptionFilters.excludesGroups('cordova-cli');
   const results = filterCommandLineOptions(metadata.options ? metadata.options : [], options, o => excludesCordovaGroup(o) || includesAppScriptsGroup(o));
 
   return {
     ...results,
-    externalAddressRequired: options['native-run'] ? false : true,
+    externalAddressRequired,
     nobrowser: true,
     engine: 'cordova',
-    platform: platform ? platform : (options['platform'] ? String(options['platform']) : undefined),
+    platform,
   };
 }

packages/ionic/src/lib/serve.ts

@@ -183,6 +183,8 @@ export abstract class ServeRunner<T extends ServeOptions> implements Runner<T, S
   }
 
   async run(options: T): Promise<ServeDetails> {
+    debug('serve options: %O', options);
+
     await this.beforeServe(options);
 
     const details = await this.serveProject(options);
@@ -220,6 +222,7 @@ export abstract class ServeRunner<T extends ServeOptions> implements Runner<T, S
     }
 
     emit('serve:ready', details);
+    debug('serve details: %O', details);
 
     this.scheduleAfterServe(options, details);
 
@@ -381,6 +384,12 @@ export abstract class ServeRunner<T extends ServeOptions> implements Runner<T, S
           }
         }
       }
+    } else if (options.externalAddressRequired && LOCAL_ADDRESSES.includes(options.address)) {
+      this.e.log.warn(
+        'An external host may be required to serve for this target device/platform.\n' +
+        'If you get connection issues on your device or emulator, try connecting the device to the same Wi-Fi network and selecting an accessible IP address for your computer on that network.\n\n' +
+        `You can use ${input('--address=0.0.0.0')} to run the dev server on all network interfaces, in which case an external address will be selected.\n`
+      );
     }
 
     return [ chosenIP, availableInterfaces ];