feat(slides): expose updateAutoHeight (#17208)

fixes #15079
ionic-team · Jan 22, 2019 · 835aea9 · 835aea9
1 parent a945b03
commit 835aea9
Show file tree

Hide file tree

Showing 6 changed files with 32 additions and 2 deletions.
diff --git a/angular/src/directives/proxies.ts b/angular/src/directives/proxies.ts
@@ -794,7 +794,7 @@ export class IonSlides {
     proxyOutputs(this, this.el, ['ionSlidesDidLoad', 'ionSlideTap', 'ionSlideDoubleTap', 'ionSlideWillChange', 'ionSlideDidChange', 'ionSlideNextStart', 'ionSlidePrevStart', 'ionSlideNextEnd', 'ionSlidePrevEnd', 'ionSlideTransitionStart', 'ionSlideTransitionEnd', 'ionSlideDrag', 'ionSlideReachStart', 'ionSlideReachEnd', 'ionSlideTouchStart', 'ionSlideTouchEnd']);
   }
 }
-proxyMethods(IonSlides, ['update', 'slideTo', 'slideNext', 'slidePrev', 'getActiveIndex', 'getPreviousIndex', 'length', 'isEnd', 'isBeginning', 'startAutoplay', 'stopAutoplay', 'lockSwipeToNext', 'lockSwipeToPrev', 'lockSwipes']);
+proxyMethods(IonSlides, ['update', 'updateAutoHeight', 'slideTo', 'slideNext', 'slidePrev', 'getActiveIndex', 'getPreviousIndex', 'length', 'isEnd', 'isBeginning', 'startAutoplay', 'stopAutoplay', 'lockSwipeToNext', 'lockSwipeToPrev', 'lockSwipes']);
 proxyInputs(IonSlides, ['mode', 'options', 'pager', 'scrollbar']);
 
 export declare interface IonSpinner extends StencilComponents<'IonSpinner'> {}

diff --git a/angular/test/test-app/src/app/navigation-page3/navigation-page3.component.ts b/angular/test/test-app/src/app/navigation-page3/navigation-page3.component.ts
@@ -10,7 +10,7 @@ export class NavigationPage3Component {
     private navController: NavController
   ) {}
 
-ionViewDidEnter() {
+  ionViewDidEnter() {
     this.navController.navigateRoot('/navigation/page2');
   }
 }
diff --git a/core/api.txt b/core/api.txt
@@ -999,6 +999,7 @@ ion-slides,method,slideTo,slideTo(index: number, speed?: number | undefined, run
 ion-slides,method,startAutoplay,startAutoplay() => Promise<void>
 ion-slides,method,stopAutoplay,stopAutoplay() => Promise<void>
 ion-slides,method,update,update() => Promise<void>
+ion-slides,method,updateAutoHeight,updateAutoHeight(speed?: number | undefined) => Promise<void>
 ion-slides,event,ionSlideDidChange,void,true
 ion-slides,event,ionSlideDoubleTap,void,true
 ion-slides,event,ionSlideDrag,void,true

diff --git a/core/src/components.d.ts b/core/src/components.d.ts
@@ -4189,6 +4189,10 @@ export namespace Components {
     * Update the underlying slider implementation. Call this if you've added or removed child slides.
     */
     'update': () => Promise<void>;
+    /**
+    * Force swiper to update its height (when autoHeight enabled) for the duration equal to 'speed' parameter
+    */
+    'updateAutoHeight': (speed?: number | undefined) => Promise<void>;
   }
   interface IonSlidesAttributes extends StencilHTMLAttributes {
     /**

diff --git a/core/src/components/slides/readme.md b/core/src/components/slides/readme.md
@@ -294,6 +294,22 @@ Type: `Promise<void>`
 
 
 
+### `updateAutoHeight(speed?: number | undefined) => Promise<void>`
+
+Force swiper to update its height (when autoHeight enabled) for the duration equal to 'speed' parameter
+
+#### Parameters
+
+| Name    | Type                  | Description |
+| ------- | --------------------- | ----------- |
+| `speed` | `number \| undefined` |             |
+
+#### Returns
+
+Type: `Promise<void>`
+
+
+
 
 ## CSS Custom Properties
 

diff --git a/core/src/components/slides/slides.tsx b/core/src/components/slides/slides.tsx
@@ -161,6 +161,15 @@ export class Slides implements ComponentInterface {
     swiper.update();
   }
 
+  /**
+   * Force swiper to update its height (when autoHeight enabled) for the duration equal to 'speed' parameter
+   */
+  @Method()
+  async updateAutoHeight(speed?: number) {
+    const swiper = await this.getSwiper();
+    swiper.updateAutoHeight(speed);
+  }
+
   /**
    * Transition to the specified slide.
    */