Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: update default ion-spinner to match the latest ios 14 style #22782

Closed
liamdebeasi opened this issue Jan 15, 2021 · 2 comments · Fixed by #22397
Closed

bug: update default ion-spinner to match the latest ios 14 style #22782

liamdebeasi opened this issue Jan 15, 2021 · 2 comments · Fixed by #22397
Labels
package: core @ionic/core package type: bug a confirmed bug report
Milestone

Comments

@liamdebeasi
Copy link
Contributor

Bug Report

Ionic version:

[ ] 4.x
[x] 5.x

Current behavior:

The default spinner on iOS uses the old iOS 13 style spinner.

Expected behavior:

The default ion-spinner on iOS should use the iOS 14 style:

93994513-42705f00-fd90-11ea-9189-fdb951f7cdf5

Steps to reproduce:

See: http://localhost:3333/src/components/spinner/test/basic?ionic:mode=ios

Related code:

There is an existing PR that makes these changes. We just need to review and merge.

Spinner Updates: #22397

@ionitron-bot ionitron-bot bot added the triage label Jan 15, 2021
@liamdebeasi liamdebeasi changed the title feat: update default ion-spinner to match the latest ios 14 style bug: update default ion-spinner to match the latest ios 14 style Jan 15, 2021
@liamdebeasi liamdebeasi added package: core @ionic/core package type: bug a confirmed bug report labels Jan 15, 2021
@liamdebeasi liamdebeasi added this to the 5.6.0 milestone Jan 15, 2021
@ionitron-bot ionitron-bot bot removed the triage label Jan 15, 2021
@liamdebeasi liamdebeasi modified the milestones: 5.6.0, 6.0.0 Jan 15, 2021
@liamdebeasi
Copy link
Contributor Author

Thanks for the issue. This has been resolved via #22397, and a fix will be available in an upcoming release of Ionic Framework.

@ionitron-bot
Copy link

ionitron-bot bot commented Mar 13, 2021

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Mar 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
package: core @ionic/core package type: bug a confirmed bug report
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant